Merged
Conversation
kegrimes
added
the
Preview Environment
Contributor
|
Preview branch generated at https://mpdx-9169-fix-asr-validation.d3dytjb8adxkk5.amplifyapp.com |
Contributor
Bundle sizes [mpdx-react]Compared against ffa449f No significant changes found |
wjames111
approved these changes
Feb 13, 2026
Contributor
wjames111
left a comment
wjames111
left a comment
There was a problem hiding this comment.
This looks great thanks for figuring out this bug! Quick question though, did you try disabling reinitialize on formik first? That should keep it from recalculating everytime requestData changes. No idea if it would work but just a thought.
Contributor
Author
|
I did try that and it still behaved oddly. I will try again and see if it works because I tested that pretty early, but if it does not work then I'll just merge this how it is! |
kegrimes
force-pushed
the
mpdx-9169-fix-asr-validation
branch
from
39bc6f1 to
0c55aa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ASR formik validation is behaving strangely where the additional info error will disappear occasionally. Looking into the issue.
Found: It was some sort of timing issue. After saving a value, the data was refetched which causes the initial values to get recalculated. Because of this, the form gets reset and doesn't pick up on the errors again until the user touches a field.
Not sure if this is the best solution, but it works for now.
Testing
/reports/additionalSalaryRequestChecklist:
/pr-reviewcommand locally and fixed any relevant suggestions