Skip to content

MPDX-9305 Add single/married cap logic to ASR#1636

Open
kegrimes wants to merge 6 commits intomainfrom
mpdx-9305-asr-combined-cap-logic
Open

MPDX-9305 Add single/married cap logic to ASR#1636
kegrimes wants to merge 6 commits intomainfrom
mpdx-9305-asr-combined-cap-logic

Conversation

@kegrimes
Copy link
Contributor

@kegrimes kegrimes commented Feb 13, 2026

Description

There are different submit modals that should show based on individual cap and, if married, spouse cap. We already have an single user's exceeding cap logic, so we need to add a married user's logic to the front end. Also, we need to account for a married couple staying under their combined cap.

Note: $5,000 is the hardcoded individual cap which will be reverted once this PR is tested and ready for production!

Testing

Testing for Single && under cap:

  • Go to /reports/additionalSalaryRequest
  • Enter in an input under $5000
  • Check that correct modal appears
Screenshot 2026-02-13 at 9 34 07 AM

Testing for Single && exceeding cap:

  • Enter in an input over $5000
  • Ensure accordions appear
  • Check that correct modal appears
Screenshot 2026-02-13 at 9 35 48 AM

Before testing Married couple, you need to hard code a few things: individual cap ($5000) and total ($4000)

// useSalaryCalculations.ts --> change spouseExceedsCap and underCombinedCap
const spouseExceedsCap = 4000 > 5000;
const underCombinedCap = true;

Testing for Married && exceeding cap && spouse under cap && under combined cap:

  • Ensure accordions are present
  • Check that correct modal appears
  • Note: Spouse's name will not appear because of the testing account
Screenshot 2026-02-13 at 9 41 15 AM

Testing for Married && exceeding cap && spouse over cap OR Married && exceeding cap && spouse under cap && over combined cap:

  • Replace 4000 with 6000 in spouseExceedsCap
  • Ensure accordions are present
  • Check that correct modal appears
  • THEN, replace 6000 with 4000 (spouseExceedsCap) and replace true with false (underCombinedCap)
Screenshot 2026-02-13 at 9 35 48 AM

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
  • I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
  • I have requested a review from another person on the project
  • I have tested my changes in preview or in staging
  • I have cleaned up my commit history

@kegrimes kegrimes added the Preview Environment Add this label to create an Amplify Preview label Feb 13, 2026
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Bundle sizes [mpdx-react]

Compared against f0f1086

No significant changes found

@kegrimes kegrimes requested review from canac and wjames111 February 13, 2026 20:57
@kegrimes
Copy link
Contributor Author

@wjames111 @canac I tried to get this PR done as quickly as possible, so I had Claude write some of the tests for me (sorry if they are messy)! Let me know if these calculations and logic are correct. I think this is what Will and I settled on, but not 100% confident. All the scenarios listed above should be working though. I did hardcode some values and you will have to change them based on the difference situations (listed above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant