MPDX-9305 Add single/married cap logic to ASR#1636
Open
Conversation
Contributor
|
Preview branch generated at https://mpdx-9305-asr-combined-cap-logic.d3dytjb8adxkk5.amplifyapp.com |
Contributor
Bundle sizes [mpdx-react]Compared against f0f1086 No significant changes found |
Contributor
Author
|
@wjames111 @canac I tried to get this PR done as quickly as possible, so I had Claude write some of the tests for me (sorry if they are messy)! Let me know if these calculations and logic are correct. I think this is what Will and I settled on, but not 100% confident. All the scenarios listed above should be working though. I did hardcode some values and you will have to change them based on the difference situations (listed above). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are different submit modals that should show based on individual cap and, if married, spouse cap. We already have an single user's exceeding cap logic, so we need to add a married user's logic to the front end. Also, we need to account for a married couple staying under their combined cap.
Note: $5,000 is the hardcoded individual cap which will be reverted once this PR is tested and ready for production!
Testing
Testing for
Single&& under cap:/reports/additionalSalaryRequest$5000Testing for
Single&& exceeding cap:$5000Before testing Married couple, you need to hard code a few things: individual cap ($5000) and total ($4000)
Testing for
Married&& exceeding cap && spouse under cap && under combined cap:Testing for
Married&& exceeding cap && spouse over cap ORMarried&& exceeding cap && spouse under cap && over combined cap:4000with6000in spouseExceedsCap6000with4000(spouseExceedsCap) and replacetruewithfalse(underCombinedCap)Checklist:
/pr-reviewcommand locally and fixed any relevant suggestions