Open
Conversation
Contributor
Bundle sizes [mpdx-react]Compared against ffa449f No significant changes found |
Contributor
|
Preview branch generated at https://MPDX-ASR-fixes.d3dytjb8adxkk5.amplifyapp.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes showSavingStatus
Adds print Action to StatusCard
Removes some dead code
Testing
Go to ASR page
Check the saving status in the top right corner only shows during the main form page.
Check that it does not show in the overview page, in progress page, about page, receipt page or view page
Set ASR status to action_required or pending in mpdx staging db
Go to ASR page
Check you have been taken to the overview page and cards displays your request
Click the print icon on the top right of the card
Ensure you are taken to the view page and that the print modal pops up
Checklist:
/pr-reviewcommand locally and fixed any relevant suggestions