Open
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
dr-bizz
requested changes
Oct 24, 2023
dr-bizz
requested changes
Oct 30, 2023
Contributor
dr-bizz
left a comment
dr-bizz
left a comment
There was a problem hiding this comment.
Looking good. Still needs a few changes
dr-bizz
requested changes
Nov 1, 2023
Contributor
dr-bizz
left a comment
dr-bizz
left a comment
There was a problem hiding this comment.
Everything looks great. Just need to update ReadMe.
canac
reviewed
Nov 8, 2023
Contributor
canac
left a comment
canac
left a comment
There was a problem hiding this comment.
Code looks great and works locally! I just had a couple of suggestions for simplifying the tests.
Contributor
|
Is the query you're using in production yet? That might be the source of the GHA failures. |
canac
approved these changes
Nov 8, 2023
Contributor
canac
left a comment
canac
left a comment
There was a problem hiding this comment.
Once https://github.com/CruGlobal/mpdx_api/pull/2728 is merged, the tests will hopefully pass and this will be good to go!
dr-bizz
approved these changes
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add notification so many users know they need to move out of MPDX
https://jira.cru.org/browse/MPDX-7790
Changes Made