Skip to content

Depreciated ViewManager.viewClass() calls are redirected to ClassManager.viewClass() #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnny-hausman merged 6 commits into from
Feb 15, 2026
Merged

Depreciated ViewManager.viewClass() calls are redirected to ClassManager.viewClass() #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
db19759
[fix] new plugin architecture should pull views from AB.ClassManager.…
johnny-hausman Feb 15, 2026
4cd660a
[fix] ABViewMenu editor should return a single {layout} around the menu.
johnny-hausman Feb 15, 2026
dcd2e9d
[wip] remove all depreciated references to ABViewManager.viewClass() …
johnny-hausman Feb 15, 2026
ce8a5ed
[wip] updated package-lock.json
johnny-hausman Feb 15, 2026
a318b14
[fix] improper call to ViewTabEditor .super()
johnny-hausman Feb 15, 2026
b60d410
[wip] clean up unnecessary assignments in Tab Editor constructor
johnny-hausman Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions src/plugins/web_view_tab/FNAbviewtabEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,9 @@ export default function FNAbviewtabEditor({ AB, ABViewEditorPlugin }) {

constructor(view, base = BASE_ID) {
// base: {string} unique base id reference
super(base, {
super(view, base, {
view: "",
});

this.AB = AB;
this.view = view;
this.component = this.view.component();
}

ui() {
Expand Down
2 changes: 1 addition & 1 deletion src/rootPages/Designer/editors/views/ABViewContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default function (AB) {
ui() {
let key = ABViewContainerEditor.key;
let Defaults =
AB.Class.ABViewManager.viewClass(key).defaultValues();
AB.ClassManager.viewClass(key).defaultValues();
return {
_dashboardID: this.ids.component,
rows: [
Expand Down
9 changes: 9 additions & 0 deletions src/rootPages/Designer/editors/views/ABViewMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,19 @@ export default function (AB) {
ui() {
const menu = this.component.ui();

// NOTE: we want our editors to have a { layout .rows[0]=component } structure
// the menu already has a layout around it, so just use that one
// and prepare it for the ABDesigner editor format:
menu._dashboardID = this.component.ids.menu;

return menu;
/*
return {
_dashboardID: this.component.ids.menu,
type: "space",
rows: [menu, {}],
};
*/
}

init(AB) {
Expand Down
2 changes: 1 addition & 1 deletion src/rootPages/Designer/properties/mobile/ABMobileViewForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ export default function (AB) {
refreshDefaultButton() {
const ids = this.ids;
const ABViewFormButton =
this.AB.Class.ABViewManager.viewClass("button");
this.AB.ClassManager.viewClass("button");

// If default button is not exists, then skip this
let defaultButton = this.views(
Expand Down
2 changes: 1 addition & 1 deletion src/rootPages/Designer/properties/views/ABViewConditionalContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default function (AB) {
});

this.AB = AB;
ABViewPropertyDefaults = this.AB.Class.ABViewManager.viewClass(
ABViewPropertyDefaults = this.AB.ClassManager.viewClass(
"conditionalcontainer"
).defaultValues();
}
Expand Down
2 changes: 1 addition & 1 deletion src/rootPages/Designer/properties/views/ABViewDataview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default function (AB) {

this.AB = AB;
ABViewDataviewPropertyComponentDefaults =
this.AB.Class.ABViewManager.viewClass("dataview").defaultValues();
this.AB.ClassManager.viewClass("dataview").defaultValues();

this.linkPageComponent = new LinkPageProperty(AB, base);
}
Expand Down
2 changes: 1 addition & 1 deletion src/rootPages/Designer/properties/views/ABViewDetail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default function (AB) {

this.AB = AB;
ABViewDetailPropertyComponentDefaults =
this.AB.Class.ABViewManager.viewClass("detail").defaultValues();
this.AB.ClassManager.viewClass("detail").defaultValues();
}

static get key() {
Expand Down
2 changes: 1 addition & 1 deletion src/rootPages/Designer/properties/views/ABViewDocxBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export default function (AB) {

this.AB = AB;
ABViewDocxBuilderPropertyComponentDefaults =
this.AB.Class.ABViewManager.viewClass(
this.AB.ClassManager.viewClass(
"docxBuilder"
).defaultValues();
}
Expand Down
4 changes: 2 additions & 2 deletions src/rootPages/Designer/properties/views/ABViewForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export default function (AB) {

this.AB = AB;
ABViewFormPropertyComponentDefaults =
this.AB.Class.ABViewManager.viewClass("form").defaultValues();
this.AB.ClassManager.viewClass("form").defaultValues();
}

static get key() {
Expand Down Expand Up @@ -600,7 +600,7 @@ export default function (AB) {
refreshDefaultButton() {
const ids = this.ids;
const ABViewFormButton =
this.AB.Class.ABViewManager.viewClass("button");
this.AB.ClassManager.viewClass("button");

// If default button is not exists, then skip this
let defaultButton = this.views(
Expand Down
6 changes: 4 additions & 2 deletions src/rootPages/Designer/properties/views/ABViewMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export default function (AB) {

this.AB = AB;
ABViewMenuPropertyComponentDefaults =
this.AB.Class.ABViewManager.viewClass("menu").defaultValues();
this.AB.ClassManager.viewClass("menu").defaultValues();
}

static get key() {
Expand Down Expand Up @@ -775,7 +775,9 @@ export default function (AB) {
});

// add tabs
const ABViewTab = this.AB.Class.ABViewManager.viewClass("tab");
// ABViewManager.viewClass() is depreciated. Use ClassManager.viewClass() instead.
//const ABViewTab = this.AB.Class.ABViewManager.viewClass("tab");
const ABViewTab = this.AB.ClassManager.viewClass("tab");
page
.views((v) => v instanceof ABViewTab)
.forEach((tab, tabIndex) => {
Expand Down
2 changes: 1 addition & 1 deletion src/rootPages/Designer/ui_work_interface_workspace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default function (AB) {
this.ColumnEditor = ABWorkspaceEditor(AB);
this.ColumnDetails = ABWorkspaceDetails(AB);

this.classABViewPage = AB.Class.ABViewManager.viewClass("page");
this.classABViewPage = AB.ClassManager.viewClass("page");
}

// webix UI definition:
Expand Down
Loading