DRY refactor, plan form extraction & Binance USDC (v2.6.1)#76
Merged
Conversation
Extract duplicated plan configuration logic (crypto/fiat/amount/frequency/ strategy/withdrawal/target) from AddPlan, FirstPlan, and EditPlan into shared PlanFormDelegate (ViewModel logic) and PlanFormContent (Composable). This eliminates ~450 lines of duplicated code and gives FirstPlan features it was missing: MonthlyCostEstimateCard, address validation, and isFormValid. Also fix CompletionScreen to show context-aware "what's next" steps based on whether the user created a plan during onboarding (persisted via prefs). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ar migration & Binance fixes - Extract CredentialFormDelegate shared across 4 ViewModels (AddPlan, Onboarding, AddExchange, ExchangeDetail) - Extract ApiImportResultDialog replacing ~30-line inline dialogs in 3 screens - Migrate 11 screens to AccBotTopAppBar - Extract KuCoin signedRequest() helper in OtherExchanges - Add NumberFormatters.roiValues() used by Dashboard and PlanDetails - Binance: switch from USDT to USDC, lower min order size to 5 - Quick amount presets: 5, 10, 25, 50, 100 (was 25–500) - Default plan amount set to exchange min order size - Strip trailing zeros from min order size display - Add USDC icon and MarketDataService mapping Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Crynners
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code