reliability(patterns): atomic save of usage cache#14
Open
CryptoJones wants to merge 1 commit into
Open
Conversation
\`socrates patterns review\` on a CompanyOS with many projects can take seconds to walk every .md file. A SIGINT during the final \`(patterns_dir / .usage-cache.json).write_text(...)\` previously left a truncated/invalid file. The next run's \`_load_usage_cache\` would JSONDecodeError on the partial file and return None — silently discarding ALL cached segments and forcing a full re-scan. (The current load already swallows the JSONDecodeError into None; the bug is the silent cache reset, not a crash.) Fix: same atomic-write pattern as interview.py's save — \`<file>.tmp\` + os.replace. Cache is either fully old or fully new, never half. Tempfile cleaned up on both success and failure paths. Tests added (2): - post-save: no .tmp leftover - mid-save os.replace failure: pre-existing cache survives intact, no .tmp leftover 149/149 tests pass; ruff + mypy clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`socrates patterns review` on a CompanyOS with many projects can take
seconds to walk every .md file. A SIGINT during the final
`(patterns_dir / .usage-cache.json).write_text(...)` previously left a
truncated/invalid file. The next run's `_load_usage_cache` would
JSONDecodeError on the partial file and return None — silently
discarding ALL cached segments and forcing a full re-scan. (The current
load already swallows the JSONDecodeError into None; the bug is the
silent cache reset, not a crash.)
Fix: same atomic-write pattern as interview.py's save —
`.tmp` + os.replace. Cache is either fully old or fully new,
never half. Tempfile cleaned up on both success and failure paths.
Tests added (2):
no .tmp leftover
149/149 tests pass; ruff + mypy clean.
Self-review caveat: duplicates the atomic-write logic in #refactor/shared-atomic-write-and-decide-lock (which extracts it to _atomic.py). Merge order: refactor first → rebase this onto the shared helper. Functionally correct either way.