bugfix(onboard): derive active sprint from directories, not hardcoded '001'#9
Open
CryptoJones wants to merge 1 commit into
Open
bugfix(onboard): derive active sprint from directories, not hardcoded '001'#9CryptoJones wants to merge 1 commit into
CryptoJones wants to merge 1 commit into
Conversation
… "001" `_synthesize_from_answers` hardcoded the sprint label to "**001 — Discovery & Architecture**" on every WELCOME.md generation, regardless of the project's actual progress. A project that had advanced through Sprint 005 still got a welcome page introducing collaborators to a sprint that closed months ago — exactly the kind of stale-handoff onboard is meant to prevent. The markdown-fallback path had a related drift: it read the active sprint from a free-text STATE.md section, which goes stale the moment the operator forgets to update STATE.md between sprints. Both paths now share a single ground-truth source: the highest-numbered canonical sprint folder under planning/sprints/ (matched by ^NNN-). Stray dirs (draft/, notes/, backup-002/) are ignored. Added _format_sprint_label() that converts planning/sprints/005-rebate-engine into **005 — Rebate Engine** Tests added (2): - project with a 005-rebate-engine dir → WELCOME.md says "005 / Rebate Engine", not "001 / Discovery & Architecture" - stray non-canonical dirs (draft/, backup-002/, notes/) are ignored — the canonical 001 still wins as the active sprint 149/149 tests pass; ruff + mypy clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_synthesize_from_answershardcoded the sprint label to"001 — Discovery & Architecture"
on every WELCOME.md generation, regardless of the project's actual
progress. A project that had advanced through Sprint 005 still got
a welcome page introducing collaborators to a sprint that closed
months ago — exactly the kind of stale-handoff onboard is meant to
prevent.
The markdown-fallback path had a related drift: it read the active
sprint from a free-text STATE.md section, which goes stale the
moment the operator forgets to update STATE.md between sprints.
Both paths now share a single ground-truth source: the highest-numbered
canonical sprint folder under planning/sprints/ (matched by ^NNN-).
Stray dirs (draft/, notes/, backup-002/) are ignored.
Added _format_sprint_label() that converts
planning/sprints/005-rebate-engine
into
005 — Rebate Engine
Tests added (2):
Rebate Engine", not "001 / Discovery & Architecture"
ignored — the canonical 001 still wins as the active sprint
149/149 tests pass; ruff + mypy clean.
Self-review caveat: the two synthesis paths (_synthesize_from_answers vs _synthesize_from_markdown) emit slightly different fallback strings when no canonical sprint dir exists. Minor cosmetic inconsistency.