Skip to content

chore(rec-28): drop DBTraceCodeUnitTest.testFigureOutAssembly println-only exploration — wip sweep #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CryptoJones merged 1 commit into from
May 26, 2026
+2 −11
Merged

chore(rec-28): drop DBTraceCodeUnitTest.testFigureOutAssembly println-only exploration — wip sweep #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions ...mework-TraceModeling/src/test/java/ghidra/trace/database/listing/DBTraceCodeUnitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import org.junit.*;

import db.*;
import ghidra.app.plugin.assembler.*;
import ghidra.docking.settings.Settings;
import ghidra.program.model.address.*;
import ghidra.program.model.data.*;
Expand Down Expand Up @@ -848,14 +847,6 @@ public void testGetBytes() throws Exception {
assertEquals(new BigInteger("-115", 16), lil.getBigInteger(0, 2, true));
}

@Test
@Ignore("wip: Debug/TraceModeling cluster #189")
public void testFigureOutAssembly() throws AssemblySyntaxException, AssemblySemanticException {
Assembler asm = Assemblers.getAssembler(b.language);
System.out.println(
NumericUtilities.convertBytesToString(asm.assembleLine(b.addr(0x4024), "call 0x4004")));
}

@Test
public void testDataValueGetters()
throws TraceOverlappedRegionException, CodeUnitInsertionException {
Expand Down
4 changes: 2 additions & 2 deletions docs/testing/ignore-test-inventory.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ Live count from `grep -rn '@Ignore("' Ghidra --include='*.java' | grep -v Repeat

| Category | Count |
|---|---|
| `wip` | 36 |
| `wip` | 35 |
| `blocked-on` | 19 |
| `manual-tool` | 1 |
| `flaky` | 0 |
| **Total properly-categorized** | **56** |
| **Total properly-categorized** | **55** |

The `manual-tool` count dropped from 10 → 8 and `flaky` from 3 → 0 in [PR #28-6a](#sequencing): five method-level `@Ignore` lines were removed because their enclosing classes are already `@Ignore`'d at class level (two in `JdiExperimentsTest`/`ProjectExperimentsTest`, three in `JavaMethodsTest`). The method annotations were dead — the class-level annotation skipped them first. Issue references (#178, #190, #193) remain valid; if the class-level ignores are ever lifted, those issues can be re-attached at the method level.

Expand Down
Loading