chore(rec-28): drop DBTraceAddressSnapRangePropertyMapSpaceTest.testRemove TODO-throw stub — wip sweep#40
Merged
CryptoJones merged 1 commit intoMay 26, 2026
Conversation
…emove TODO-throw stub — wip sweep Rec 28 #28-6d+ active-@ignore sweep, eleventh wip-bucket deletion. The removed method has real setup, but a bare `TODO()` mid-body kills the remainder before the post-second-remove assertion can run: @test @ignore("wip: Debug/TraceModeling cluster NationalSecurityAgency#189") public void testRemove() { try (Transaction tx = obj.openTransaction("Create entries")) { ... assertTrue(obj.space1.remove(entry1)); assertTrue(obj.space1.isEmpty()); assertTrue(entry1.getValue().isDeleted()); assertTrue(obj.space2.remove(entry1)); // TODO: Should match by shape? TODO(); // <-- throws, dead code below assertTrue(obj.space2.isEmpty()); MyEntry value = obj.space1.put(at(0x1000, 5), null); ... } } `TODO()` throws UnsupportedOperationException, so the second half of the test was never being exercised. The author's open question "Should match by shape?" was not resolved into a real expected. Issue NationalSecurityAgency#189 retains the open-question record. fix-or-delete: delete. The TODO static import stays — `testSaveAndLoad` at line 397 (also @ignore'd) is the file's other consumer of `ghidra.lifecycle.Unfinished.TODO`. Updates docs/testing/ignore-test-inventory.md: - wip: 34 → 33 - total properly-categorized: 54 → 53 Closes NationalSecurityAgency#189 (testRemove portion). Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/ Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rec 28 #28-6d+ active-
@Ignoresweep, eleventh wip-bucket deletion. The removed method has real setup, but a bareTODO()mid-body kills the remainder before the post-second-remove assertion can run:TODO()throwsUnsupportedOperationException, so the second half of the test was never being exercised. The author's open question "Should match by shape?" was not resolved into a real expected. Issue NationalSecurityAgency#189 retains the open-question record.fix-or-delete: delete. The
TODOstatic import stays —testSaveAndLoad(also@Ignore'd) is the file's other consumer ofghidra.lifecycle.Unfinished.TODO.Updates
docs/testing/ignore-test-inventory.md:Closes NationalSecurityAgency#189 (testRemove portion).
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/