Skip to content

chore(rec-28): drop DBTraceAddressSnapRangePropertyMapSpaceTest.testRemove TODO-throw stub — wip sweep#40

Merged
CryptoJones merged 1 commit into
masterfrom
chore/rec-28-delete-DBTraceAddressSnapRange-testRemove
May 26, 2026
Merged

chore(rec-28): drop DBTraceAddressSnapRangePropertyMapSpaceTest.testRemove TODO-throw stub — wip sweep#40
CryptoJones merged 1 commit into
masterfrom
chore/rec-28-delete-DBTraceAddressSnapRange-testRemove

Conversation

@CryptoJones
Copy link
Copy Markdown
Owner

Rec 28 #28-6d+ active-@Ignore sweep, eleventh wip-bucket deletion. The removed method has real setup, but a bare TODO() mid-body kills the remainder before the post-second-remove assertion can run:

@Test
@Ignore("wip: Debug/TraceModeling cluster #189")
public void testRemove() {
    try (Transaction tx = obj.openTransaction("Create entries")) {
        ...
        assertTrue(obj.space1.remove(entry1));
        assertTrue(obj.space1.isEmpty());
        assertTrue(entry1.getValue().isDeleted());
        assertTrue(obj.space2.remove(entry1)); // TODO: Should match by shape?
        TODO();                                 // <-- throws, dead code below
        assertTrue(obj.space2.isEmpty());
        ...
    }
}

TODO() throws UnsupportedOperationException, so the second half of the test was never being exercised. The author's open question "Should match by shape?" was not resolved into a real expected. Issue NationalSecurityAgency#189 retains the open-question record.

fix-or-delete: delete. The TODO static import stays — testSaveAndLoad (also @Ignore'd) is the file's other consumer of ghidra.lifecycle.Unfinished.TODO.

Updates docs/testing/ignore-test-inventory.md:

  • wip: 34 → 33
  • total properly-categorized: 54 → 53

Closes NationalSecurityAgency#189 (testRemove portion).

Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/

…emove TODO-throw stub — wip sweep

Rec 28 #28-6d+ active-@ignore sweep, eleventh wip-bucket deletion.
The removed method has real setup, but a bare `TODO()` mid-body kills
the remainder before the post-second-remove assertion can run:

    @test
    @ignore("wip: Debug/TraceModeling cluster NationalSecurityAgency#189")
    public void testRemove() {
        try (Transaction tx = obj.openTransaction("Create entries")) {
            ...
            assertTrue(obj.space1.remove(entry1));
            assertTrue(obj.space1.isEmpty());
            assertTrue(entry1.getValue().isDeleted());
            assertTrue(obj.space2.remove(entry1)); // TODO: Should match by shape?
            TODO();                                 // <-- throws, dead code below
            assertTrue(obj.space2.isEmpty());
            MyEntry value = obj.space1.put(at(0x1000, 5), null);
            ...
        }
    }

`TODO()` throws UnsupportedOperationException, so the second half of
the test was never being exercised. The author's open question
"Should match by shape?" was not resolved into a real expected. Issue
NationalSecurityAgency#189 retains the open-question record.

fix-or-delete: delete. The TODO static import stays — `testSaveAndLoad`
at line 397 (also @ignore'd) is the file's other consumer of
`ghidra.lifecycle.Unfinished.TODO`.

Updates docs/testing/ignore-test-inventory.md:
- wip: 34 → 33
- total properly-categorized: 54 → 53

Closes NationalSecurityAgency#189 (testRemove portion).

Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@CryptoJones CryptoJones merged commit c5b682f into master May 26, 2026
10 of 11 checks passed
@CryptoJones CryptoJones deleted the chore/rec-28-delete-DBTraceAddressSnapRange-testRemove branch May 26, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support force loading of PDB files

1 participant