chore(rec-28): drop testOnSyscallMemory empty-stubs in DbgEng + Gdb hooks tests — wip sweep#41
Merged
CryptoJones merged 1 commit intoMay 26, 2026
Conversation
…ooks tests — wip sweep Rec 28 #28-6d+ active-@ignore sweep, twelfth wip-bucket deletion. Two parallel-copy empty-bodied stubs across the dbgeng and gdb RMI hook test files: Ghidra/Test/.../agent/dbgeng/rmi/DbgEngHooksTest.java:194-199 Ghidra/Test/.../agent/gdb/rmi/GdbHooksTest.java:256-261 Both have identical body content (none — just two comment lines): @test @ignore("wip: Debugger RMI integration tests — undocumented bare-ignore NationalSecurityAgency#179") public void testOnSyscallMemory() throws Exception { // TODO: Need a specimen // FWIW, I've already seen this getting exercised in other tests. } The author's own comment "I've already seen this getting exercised in other tests" is the fix-or-delete answer: coverage exists elsewhere, the stub is decorative. Same dead-stub pattern as the DebuggerOpinionsTest / DBTraceRegisterContextManagerTest deletions (#30, #31). Issue NationalSecurityAgency#179 retains the RMI integration cluster record. The unused `import org.junit.Ignore` drops out of both files. Updates docs/testing/ignore-test-inventory.md: - wip: 33 → 31 - total properly-categorized: 53 → 51 Closes NationalSecurityAgency#179 (testOnSyscallMemory portion in DbgEng + Gdb). Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/ Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CryptoJones
deleted the
chore/rec-28-delete-testOnSyscallMemory-empty-stubs
branch
CryptoJones
added a commit
that referenced
this pull request
May 26, 2026
Bookkeeping for the day's Rec 28 #28-6d+ work. The session deleted 17 author-declared-not-a-regression-test sites across PRs #26–#34 and #36–#41: Empty TODO() stubs: DebuggerOpinionsTest, DBTraceRegisterContextManagerTest, AbstractToyJitCodeGeneratorTest.testComputedOffsetsInRegisterSpace, AbstractToyJitCodeGeneratorTest.testUninitializedVsInitializedReads, DbgEngHooksTest.testOnSyscallMemory, GdbHooksTest.testOnSyscallMemory Manual JFrame demos: DemoFieldsTest, DebuggerManualTest, TenetLoaderTest.testManual println-only / perf: experiments/ToArrayTest, DBTraceCodeUnitTest.testFigureOutAssembly, AbstractDBTraceMemoryManagerMemoryTest.testReplicateClassCastExceptionScenario, DebuggerMemoryBytesProviderTest.testPerformanceManuallyWithManyManySnaps, CharsetInfoManagerTest.generateCharsetInfoFile Commented-body shell: CppCompositeTypeTest.testJ5_32_syntactic_layout TODO-throw-mid-body: DBTraceProgramViewListingTest.testGetUndefinedRanges, DBTraceAddressSnapRangePropertyMapSpaceTest.testRemove JdiExperimentsTest (file): already deleted in earlier sweep, listed for completeness. Census after the sweep: - wip: 46 → 31 - blocked-on: 19 (unchanged — all real upstream blockers) - manual-tool: 8 → 1 (JitJvmTypeUtilsTest remains; Java-version-bound, infra fix not delete) - flaky: 0 - total: 73 → 51 The "author-declared not-a-regression-test" sub-bucket is now empty across both manual-tool and wip categories. The remaining 51 entries all have real bodies; the residual sweep work is fix-the-real-blocker, not delete-the-stub. Snapshot date updated to 2026-05-26. Sequencing #28-6d+ row and heuristics §4 updated to reflect the new composition. Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/ Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rec 28 #28-6d+ active-
@Ignoresweep, twelfth wip-bucket deletion. Two parallel-copy empty-bodied stubs across the dbgeng and gdb RMI hook test files. Both have identical body content (none — just two comment lines):The author's own comment "I've already seen this getting exercised in other tests" is the fix-or-delete answer: coverage exists elsewhere, the stub is decorative. Same dead-stub pattern as the
DebuggerOpinionsTest/DBTraceRegisterContextManagerTestdeletions (#30, #31). Issue NationalSecurityAgency#179 retains the RMI integration cluster record.The unused
import org.junit.Ignoredrops out of both files.Updates
docs/testing/ignore-test-inventory.md:Closes NationalSecurityAgency#179 (testOnSyscallMemory portion in DbgEng + Gdb).
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/