chore(rec-28): flip ignoreAudit Stage 1→2 — strict-by-default now backlog is clear#43
Merged
Conversation
…klog is clear Rec 28 #28-6d+ closes out: the audit task now defaults to fail-on- violation locally as well as in CI. Status: the Rec 28 #28-5..#28-6d+ sweep cleared every author-declared- not-a-regression-test stub (DemoFieldsTest, DebuggerManualTest, experiments/ToArrayTest, the TODO()-stub family, etc.). The remaining 51 @ignore annotations all carry a category prefix (flaky / blocked-on / wip / manual-tool) and a tracking-issue #N reference — the audit finds zero violations. Before: boolean strict = project.hasProperty('ignoreAuditStrict') && project.property('ignoreAuditStrict') == 'true' # default → warn-only; -PignoreAuditStrict=true → fail After: boolean strict = !(project.hasProperty('ignoreAuditStrict') && project.property('ignoreAuditStrict') == 'false') # default → fail; -PignoreAuditStrict=false → warn (for triage) The CI workflow still passes -PignoreAuditStrict=true explicitly; the flag is now redundant but harmless and the literal value documents intent on the workflow side. This brings the gradle task's default in line with what docs/testing/IGNORE_TEST_POLICY.md has already documented as "Stage 2 (failing, current — flipped 2026-05-21)". Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/ Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CryptoJones
added a commit
that referenced
this pull request
May 26, 2026
#44) - Sprint 6 #32-2 (c++11 → c++14): marked shipped, link to PR NationalSecurityAgency#310. - Sprint 6 #32-3 (c++14 → c++20): marked shipped, link to PR NationalSecurityAgency#314 (rolled in alongside the dd-005 doc update; same 3 sites as #32-2; flag-only change recorded in docs/decompiler/CPP20_ADOPTION.md). - Sprint 6 quick-win Rec 28 #28-6+ sweep: marked shipped — the author-declared-not-a-regression-test sub-bucket is empty, the ignoreAudit task is now Stage 2 strict-by-default (PR #43), and the residual 51 entries are real tests blocked on real upstream work (fix-the-real-blocker scope, not delete-the-stub). No code change — bookkeeping only. The actual implementation work already landed; this commit just stops the planning doc from showing them as open. Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/ Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rec 28 #28-6d+ closes out: the audit task now defaults to fail-on-violation locally as well as in CI.
Status: the Rec 28 #28-5..#28-6d+ sweep cleared every author-declared-not-a-regression-test stub (
DemoFieldsTest,DebuggerManualTest,experiments/ToArrayTest, theTODO()-stub family, etc.). The remaining 51@Ignoreannotations all carry a category prefix (flaky/blocked-on/wip/manual-tool) and a tracking-issue#Nreference — the audit finds zero violations.Before:
After:
The CI workflow still passes
-PignoreAuditStrict=trueexplicitly; the flag is now redundant but harmless and the literal value documents intent on the workflow side.This brings the gradle task's default in line with what
docs/testing/IGNORE_TEST_POLICY.mdhas already documented as "Stage 2 (failing, current — flipped 2026-05-21)".Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/