refactor(cors): expose Link/X-Request-Id/Idempotency-Replay/RateLimit-* globally#94
Merged
Merged
Conversation
…-* globally
Browser JS clients hitting the API cross-origin couldn't read most
of the useful response headers — CORS hides everything outside the
safelist unless `Access-Control-Expose-Headers` covers it
explicitly.
Two changes:
1. **server.js**: cors() middleware gains an `exposedHeaders` list
covering Link, X-Request-Id, Idempotency-Replay, and the three
RateLimit-* headers that express-rate-limit emits. One declaration
instead of N per-controller setHeader calls; covers every route
uniformly including error paths.
2. **app/controllers/*.js**: 15 list endpoints previously did
`res.setHeader('Access-Control-Expose-Headers', 'Link')` after
setting the Link header itself. With the global CORS declaration
in place those are redundant — removed across the board.
Tests:
- New `tests/api/cors-expose-headers.test.js` (2 cases) pins
the exposed header set on a cross-origin response AND asserts
no controller hand-rolls the expose header (regression guard
against the redundant pattern coming back).
- Full suite: 474 pass / 4 skip (was 472/4).
- Lint clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server.jscors() gains anexposedHeaderslist covering Link, X-Request-Id, Idempotency-Replay, and the three RateLimit-* headers from express-rate-limit. One global declaration; covers error paths too.Access-Control-Expose-Headers: Link— now removed (redundant).Test plan
tests/api/cors-expose-headers.test.js(2 cases): asserts the exposed-headers set + pins the "no controller hand-rolls it" cleanup.This code proudly made in Nebraska. GO BIG RED! 🌽 https://xkcd.com/2347/