Conversation
added 2 commits
November 16, 2020 10:48
Added burning_glass to cu_js_includes_enabled in .install Added burning_glass to array in .module file at cu_js_includes_block_options() Added cu_js_includes_burning_glass_form() in .forms.inc file Added view burning_glass js includes to cu_js_includes_secure_permissions() in .permissions.inc file Added to cu_js_includes_get_include_types() in .types.inc file Added Add Burning GLass Include to [types] array in cu_js_includes_express_node_list_groups() in .types.inc file Added burning glass php template in /templates/burning_glass.php
- change name of template file's extension to .tpl.php - remove a line of code created for debugging purposes
Member
|
Last time I had mentioned this to Jo she had some concerns with this content and the direction of the academic program pages, etc. We should loop her in on this before we merge it. |
Contributor
Author
|
@kevincrafts Ok. |
cathysnider
approved these changes
Nov 17, 2020
Contributor
cathysnider
left a comment
cathysnider
left a comment
There was a problem hiding this comment.
This includes add the JS snippet to pages as specified. The snippets do not interfere with any other include that has also been added to the page.
- making sure the access_code and program_code in the burning_glass.tpl.php are output as strings - fixing bad reference to form fields in cu_js_includes.forms.inc -> cu_js_includes_burning_glass_form()
Member
|
Jo has reached out to Catherine Horning on this request - hopefully we'll get some clarification soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Burning Glass JS include:
work steps to add this feature: