Open
Conversation
…d is supported, and legacy block ids no long work with a ShowParseException
Author
|
This is working now, and I added info on how to use heads to the #3 |
CubitsDev
requested changes
Apr 22, 2022
…b)" and "ITEM_NAME:(r,g,b)"
Author
|
implemented all requested changes @CubitsDev |
Author
|
Any update on this @CubitsDev? Thanks |
Author
|
Hey, is there anything else I need to do, or is this PR ready for merging? Thanks @CubitsDev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Armor stand armor parsing didn't work at all.
Changes:
Now works with modern material names,
Offhand is supported,
Colors work,
The syntax is the same (minus id/name change).
Legacy:
Legacy numeric ids didnt work either, and I tried to fix them but everything with bukkit that involves those has been removed.
I dont think anyone actually uses those anymore, but if so someone can add them back. I think all the actions that support legacy stuff are probably also broken.
When using them now, it throws an exception.
Heads:
Cant get them to work, idk how to get the hash. Will work on this soon.