Fixed Context struct to have usize instead of i32#20
Open
wdoppenberg wants to merge 3 commits intoCurrySoftware:masterfrom
Open
Fixed Context struct to have usize instead of i32#20wdoppenberg wants to merge 3 commits intoCurrySoftware:masterfrom
wdoppenberg wants to merge 3 commits intoCurrySoftware:masterfrom
Conversation
Ngalstyan4
added a commit
to Ngalstyan4/rust-stemmers
that referenced
this pull request
Sep 13, 2024
It seems at some point snowball_env.rs has been updated in the rust snowball backend but the change is not reflected in rust-stemmers project. The right fix probably is to fix snowball_env.rs and regenerate all rust code for language-specific stemmers. But this small change at least makes the main branch compile out of the box again. See CurrySoftware#20 for an additional github action suggestion that runs tests on PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I kept getting an error as follows:
This was easily fixed by changing the
Contextstruct's fields to beusize.cargo testFurthermore, I added a basic GH Actions workflow to run cargo test.