Bug/CLARK-CLIENT-1/fix expression changed after checked error - #2242
Open
sentry[bot] wants to merge 1 commit into
Open
Bug/CLARK-CLIENT-1/fix expression changed after checked error#2242sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
ExpressionChangedAfterItHasBeenCheckedError(NG0100) occurring inClarkComponentrelated to the newsletter banner.Root Cause:
The
checkShowSubscriptionBanner()method inSubscriptionAgreementServicewas causing a synchronous state flip. WhenlocalStoragedid not containshowSubscriptionBanner,setShowSubscriptionBanner(false)was called, correctly settingthis.showSubscriptionBannertofalseand updatinglocalStorage. However, the method then continued to re-evaluatethis.showSubscriptionBannerusing a stale localbannervariable (which was stillnull), causing it to be incorrectly set totrue. On the subsequent Angular change detection cycle, the value fromlocalStoragewas correctly read asfalse, leading to atruetofalsechange between checks.Fix:
Added
returnstatements immediately after each call tothis.setShowSubscriptionBanner(false)withincheckShowSubscriptionBanner(). This ensures that oncethis.showSubscriptionBanneris correctly set tofalse(andlocalStorageupdated), the method exits, preventing the subsequent re-evaluation with the stalebannervariable that caused the state flip.Fixes CLARK-CLIENT-1