Draft
Conversation
dora1998
force-pushed
the
feat/path-from-args
branch
from
937f974 to
ad1f507
Compare
dora1998
force-pushed
the
feat/path-from-args
branch
from
ad1f507 to
2c60b30
Compare
arabian9ts
reviewed
Aug 19, 2024
Comment on lines
+6
to
+11
| let conf = ConfigBuilder::new() | ||
| .config_file_path(command.config_file_path) | ||
| .ignore_file_path(command.ignore_file_path) | ||
| .build()?; | ||
|
|
||
| let reminders = reminder_lint_core::reminders(&conf, command.search_path)?; |
Contributor
There was a problem hiding this comment.
We can pass the search path option with ConfigBuilder, then passed, it can be merged into Config. 🤔
Anything you intended?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A feature that allows you to pass the search path from command arguments has been added.
When searching frequently, such as when using an editor extension, we should search only the target files.
Example