This repository was archived by the owner on Nov 5, 2020. It is now read-only.
Feature/issue 162 vacations email notifications#166
Open
AndrewMigal wants to merge 7 commits into
Open
Conversation
| @@ -0,0 +1,4 @@ | |||
| class ApplicationMailer < ActionMailer::Base | |||
| default from: 'andrey.migal@gmail.com' | |||
There was a problem hiding this comment.
Would be good to move this into configuration.
This feature was made according to refreshed product owner's requirements. And also there are some fixes based on comments to previous commit.
AndrewMigal
force-pushed
the
feature/issue_162_vacations_email_notifications
branch
from
5702442 to
6f48bad
Compare
It shows type of vacation, vacation interval and count the vacation duration
AndrewMigal
force-pushed
the
feature/issue_162_vacations_email_notifications
branch
from
c754806 to
41d5297
Compare
AndrewMigal
force-pushed
the
feature/issue_162_vacations_email_notifications
branch
from
41d5297 to
d1ee70e
Compare
| </head> | ||
| <body> | ||
| <p><%= t('vacation_requests.confirm') %></p> | ||
| <p><%= "#{t('vacation_requests.confirm')} from #{@start_date} to #{@end_date}" %> |
Contributor
There was a problem hiding this comment.
The "confirm" seems to be confusing. Is user supposed to confirm something?
Author
There was a problem hiding this comment.
I guess I should name it 'confirmation' ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deployed in http://radiant-beyond-46287.herokuapp.com
Fixes #162