-
Notifications
You must be signed in to change notification settings - Fork 0
Add missing pipeline steps to frontend status indicator #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -260,6 +260,18 @@ $(function () { | |
| if (combined.indexOf("revise") !== -1 || combined.indexOf("revision") !== -1) { | ||
| return "Applying Chapter Revisions"; | ||
| } | ||
| if (combined.indexOf("voice & dialogue") !== -1 || combined.indexOf("voice and dialogue") !== -1) { | ||
| return "Differentiating character voices"; | ||
| } | ||
| if (combined.indexOf("human oddities") !== -1) { | ||
| return "Adding human texture"; | ||
| } | ||
|
Comment on lines
+266
to
+268
|
||
| if (combined.indexOf("metaphor reduction") !== -1) { | ||
| return "Reducing metaphor density"; | ||
| } | ||
|
Comment on lines
+269
to
+271
|
||
| if (combined.indexOf("copy edit") !== -1) { | ||
| return "Copy editing"; | ||
| } | ||
|
|
||
| return "Prompting LLM"; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition is effectively unreachable/inaccurate because an earlier check matches any
combinedcontaining "dialogue" and returns "Refining Chapter Dialog" first. Also, the rendered prompt text uses the phrase "dialogue and voice" (not "voice & dialogue" / "voice and dialogue"), so this may never match when inferring frompayload.messages. Consider moving a more specific voice+dialogue detection above the generic "dialogue" check and matching the actual prompt wording (or using a bounded regex likevoice.*dialogue/dialogue.*voice).