Fix graal.js dependencies to work with other mods, and not break on graalvm#36
Closed
wagyourtail wants to merge 1 commit intoCyclopsMC:master-1.21-ltsfrom
Closed
Fix graal.js dependencies to work with other mods, and not break on graalvm#36wagyourtail wants to merge 1 commit intoCyclopsMC:master-1.21-ltsfrom
wagyourtail wants to merge 1 commit intoCyclopsMC:master-1.21-ltsfrom
Conversation
Author
|
hopefully neoforged/JarJar#5 will result in a better solution |
Member
|
Thanks @wagyourtail! |
Member
|
Thanks for going through this effort @wagyourtail! The code is however a bit too cursed for my taste 😅 I did however see that Graal has made changes that may fix the shadow issues. So I'll await the next Graal release, and try to make it work that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is very cursed code... could probably be done a little better with a
IDependencyLocatorthat actually just checks if graalvm and then conditionally loads the deps. but this is 100x easier to write.why doesn't neo just have a way to do this in jarjar.
(maybe don't merge yet...)
also, I haven't fully tested it, just the testscript command