Optimize dashboard by moving system metrics collection to spawn_blocking#210
Optimize dashboard by moving system metrics collection to spawn_blocking#210
Conversation
- Wrap the `System` metric polling (`sys.refresh_cpu()`, etc.) inside `tokio::task::spawn_blocking` to decouple it from the main Tokio async executor. - Remove instances of `.unwrap()` when acquiring mutex locks on the `AppState` in the dashboard, replacing them with proper pattern matching to handle poisoned states gracefully. - Update `README.md` to document optimizations in both English and French.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR implements optimizations and fixes for the web dashboard, and updates the
README.mdto reflect them:tokio::task::spawn_blocking. This prevents blocking the async runtime loop and fulfills the optimization directives in memory.systemandlast_system_refreshinserver_manager/src/interface/web.rs, replacing them with safe match expressions.README.mdby adding an "Optimizations & Performance" section in both English and French describing the async I/O strategy, caching model, hardware detection logic, and zero-allocation HTML generation strategies.PR created automatically by Jules for task 17805997636092625608 started by @Cylae