This repository was archived by the owner on Aug 22, 2019. It is now read-only.
Open
Conversation
Removed Logger and Config classes Migrated debug logging and chunk checking to main plugin Fixed not using features present in BukkitRunnables TODO: Does ChatUtils offer anything of value? It doesn't appear to.
Running maven install should include resources automatically, and it most definitely did not do that before.
Renamed variables/main class to be more descriptive Fixed attempting to get chunk task by event, not chunk.
…ns rather than cull older entities.
Barely used any new features (avoided try-with-resources) and it does alienate 0.7% of server owners, according to Metrics.
EntityCompare looked to be the start of an API of sorts, but was unused. No debug messages contain color codes, useless to try to strip them.
|
Copying my writeup for #6 in here so there's a list of changes
I did my best to keep all mass formatting on separate commits so you can see the actual diffs when code was changed. The only thing I did that I would describe as odd is downgrading the Maven compiler version - for whatever reason, I could not get it to properly compile the project with resources without the changes in 944d201. I would probably add in a warning about the config option properties.prevent-creature-spawns, it has a much higher footprint than scheduled chunk culling. I only added it because it was in earlier CSL versions, it doesn't actually interest me personally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't know if this is still an issue but it caused problems with earlier versions.