Conversation
… need to be careful when dealing with fermions
… &mapper) by copying and adapting the updated cytnx_uint64 version
… legs of type BD_KET ("P gate")
…ion, also for bosonic cases
-twist_ implemented to be called by label as well
…owrank accordingly to really transpose the matrix form of a tensor
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #703 +/- ##
==========================================
+ Coverage 35.44% 36.03% +0.59%
==========================================
Files 215 215
Lines 33071 33136 +65
Branches 13170 13185 +15
==========================================
+ Hits 11723 11942 +219
+ Misses 19424 19256 -168
- Partials 1924 1938 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is it possible to add some simple unit test? |
done |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba15358496
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1) Transpose sets is_diag correctly after changing rowrank 2) Error messages print unknown labels as strings instead of integers
|
All fixed. |
3 participants
-Added fermion twists, which corresponds to the P-gates in arXiv:2404.14611
-Cleaned up code and updated documentation
-Made all methods return a pointer to the class to allow for chaining (e.g.
UniTensor.contiguous().fermion_twists(). ...)