Conversation
…(possibly with bonds removed)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #714 +/- ##
==========================================
+ Coverage 35.44% 35.55% +0.10%
==========================================
Files 215 214 -1
Lines 33071 33118 +47
Branches 13170 13191 +21
==========================================
+ Hits 11723 11776 +53
+ Misses 19424 19412 -12
- Partials 1924 1930 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is it possible to add some simple unit test? |
e65f904 to
25121c9
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25121c9397
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
set behaves like get for diagonal UniTenosrs get always returns a UniTensor with independent metadata no memory leak with empty 'removed' argument using get()
…th two accessor elements on a diagonal UniTensor this creates consistency; use one accessor element to address only the diagonal elements;
|
All issues were fixed, and unit tests were added. I changed the behavior so that slicing a diagonal-dense UniTensor with two accessors always yields a non-diagonal UniTensor. Before, the result was still diagonal if the two accessors were the same, but this led to inconsistent behavior. If the output should be diagonal, use only one accessor! |
UniTensors keep their metadata (possibly with bonds removed for constant access of one element in a given dimension).
Diagonal UniTensors can be accessed by two-dimensional slicing as well now.
This fixes #397