Skip to content

Refactor arithmetic ops to use std::variant + std::visit #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jysh1214 wants to merge 7 commits into
base: master
Choose a base branch
from

CUDA: typed dispatch for Sub/Mul/Div with mixed-dtype tests

d60ea7f
Select commit
Loading
Failed to load commit list.
Open

Refactor arithmetic ops to use std::variant + std::visit #723

CUDA: typed dispatch for Sub/Mul/Div with mixed-dtype tests
d60ea7f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 31, 2026 in 0s

36.18% (+3.83%) compared to e87c3a2

View this Pull Request on Codecov

36.18% (+3.83%) compared to e87c3a2

Details

Codecov Report

❌ Patch coverage is 15.72387% with 879 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.18%. Comparing base (e87c3a2) to head (d60ea7f).
⚠️ Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
src/linalg/Div.cpp 4.09% 232 Missing and 2 partials ⚠️
src/linalg/Sub.cpp 7.37% 221 Missing and 5 partials ⚠️
src/linalg/Mod.cpp 3.58% 188 Missing ⚠️
src/linalg/Cpr.cpp 0.00% 108 Missing ⚠️
src/linalg/Mul.cpp 25.18% 96 Missing and 5 partials ⚠️
src/linalg/Add.cpp 80.95% 3 Missing and 9 partials ⚠️
src/linalg/iArithmetic_visit.hpp 80.95% 6 Missing and 2 partials ⚠️
src/linalg/iDiv.cpp 66.66% 1 Missing ⚠️
src/linalg/iMul.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
+ Coverage   32.35%   36.18%   +3.83%     
==========================================
  Files         215      213       -2     
  Lines       36363    30579    -5784     
  Branches    14597    12655    -1942     
==========================================
- Hits        11764    11065     -699     
+ Misses      22659    17679    -4980     
+ Partials     1940     1835     -105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov