Skip to content

fixed reversed qnums infixed reversed qnums in linalg functions if combined incoming bond BdLeft is outgoing instead of incoming (#761 #763) linalg functions#764

Open
manuschneider wants to merge 2 commits intomasterfrom
fix_linalg_reversed_qnums
Open

fixed reversed qnums infixed reversed qnums in linalg functions if combined incoming bond BdLeft is outgoing instead of incoming (#761 #763) linalg functions#764
manuschneider wants to merge 2 commits intomasterfrom
fix_linalg_reversed_qnums

Conversation

@manuschneider
Copy link
Copy Markdown
Collaborator

This happens if the combined incoming bond BdLeft is outgoing instead of incoming.
Fixes #761 and #763

@manuschneider manuschneider added the Pending check/approval Issue fixed, and need feedback label Apr 1, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.45%. Comparing base (fa015d4) to head (1b9e105).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/linalg/Gesvd.cpp 10.00% 7 Missing and 2 partials ⚠️
src/linalg/Svd.cpp 30.00% 5 Missing and 2 partials ⚠️
src/linalg/Eig.cpp 20.00% 2 Missing and 2 partials ⚠️
src/linalg/Eigh.cpp 20.00% 2 Missing and 2 partials ⚠️
src/linalg/ExpH.cpp 20.00% 2 Missing and 2 partials ⚠️
src/linalg/ExpM.cpp 20.00% 2 Missing and 2 partials ⚠️
src/linalg/Qr.cpp 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   35.44%   35.45%           
=======================================
  Files         215      214    -1     
  Lines       33071    33094   +23     
  Branches    13170    13205   +35     
=======================================
+ Hits        11723    11732    +9     
- Misses      19424    19429    +5     
- Partials     1924     1933    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manuschneider manuschneider added this to the v1.1.0 milestone Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pending check/approval Issue fixed, and need feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linalg.Qr produces wrong (negative) auxiliary bond qnums for BlockUniTensor

1 participant