Skip to content

Normalize ZnSymmetry outputs into valid qnums #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yingjerkao wants to merge 1 commit into
base: master
Choose a base branch
from
+26 −5
Open

Normalize ZnSymmetry outputs into valid qnums #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/Symmetry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@ using namespace std;

namespace cytnx {

namespace {
cytnx_int64 NormalizeZnQnum(cytnx_int64 qnum, const cytnx_int64 n) {
qnum %= n;
if (qnum < 0) qnum += n;
return qnum;
}
} // namespace

bool cytnx::Symmetry::operator==(const cytnx::Symmetry &rhs) const {
return (this->stype() == rhs.stype()) && (this->n() == rhs.n());
}
Expand Down Expand Up @@ -117,19 +125,19 @@ namespace cytnx {
const std::vector<cytnx_int64> &inR) {
out.resize(inL.size() * inR.size());
for (cytnx_uint64 i = 0; i < out.size(); i++) {
out[i] = (inL[cytnx_uint64(i / inR.size())] + inR[i % inR.size()]) % (this->n);
out[i] = NormalizeZnQnum(inL[cytnx_uint64(i / inR.size())] + inR[i % inR.size()], this->n);
}
}
void cytnx::ZnSymmetry::combine_rule_(cytnx_int64 &out, const cytnx_int64 &inL,
const cytnx_int64 &inR, const bool &is_reverse) {
const cytnx_int64 combined = NormalizeZnQnum(inL + inR, this->n);
if (is_reverse)
this->reverse_rule_(out, (inL + inR) % (this->n));
this->reverse_rule_(out, combined);
else
out = (inL + inR) % (this->n);
out = combined;
}
void cytnx::ZnSymmetry::reverse_rule_(cytnx_int64 &out, const cytnx_int64 &in) {
// out = -in<0?-in+this->n:-in;
out = -in + this->n;
out = NormalizeZnQnum(-in, this->n);
}

void cytnx::ZnSymmetry::print_info() const {
Expand Down
13 changes: 13 additions & 0 deletions tests/Bond_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,19 @@ TEST(Bond, CombindBondSymm_v2) {
EXPECT_THROW(bd_sym_a.combineBond(bd_sym_g), std::logic_error);
}

TEST(Bond, ZnSymmetryNormalizesPublicRules) {
Symmetry z2 = Symmetry::Zn(2);

EXPECT_EQ(z2.combine_rule(-1, 0), 1);
EXPECT_EQ(z2.combine_rule(0, -1), 1);
EXPECT_EQ(z2.combine_rule(-1, 0, true), 1);
EXPECT_EQ(z2.reverse_rule(0), 0);
EXPECT_EQ(z2.reverse_rule(1), 1);
EXPECT_TRUE(z2.check_qnum(z2.combine_rule(-1, 0)));
EXPECT_TRUE(z2.check_qnum(z2.combine_rule(0, -1)));
EXPECT_TRUE(z2.check_qnum(z2.reverse_rule(0)));
}

TEST(Bond, Clear_type) {
Bond bd_sym = Bond(BD_KET, {{0, 2}, {3, 5}, {1, 6}, {4, 1}}, {4, 7, 2, 3});

Expand Down
Loading