Fix compaction replay dropping history on missing firstKeptEntryId#8
Merged
Merged
Conversation
…stKeptEntryId buildSessionContext walked entries [0, compactionIdx) and only began appending once it saw compaction.firstKeptEntryId. If that id was missing from the path (corruption/race — the JSONL codec only warns on load, it does not repair), foundFirstKept never flipped, so EVERY pre-compaction entry was dropped on replay — losing recent history the compaction summary does not cover. Fix: when firstKeptEntryId is absent, keep all pre-compaction entries instead of dropping them (preserve data over the kept-tail optimization). Normal replays, where the id exists, are unchanged. Verified red-before-green (a session with a bogus firstKeptEntryId loses PRECOMP messages before, keeps them after) and npm run verify green (agent 190). The other dry-run-blocked candidate (ROS_DOMAIN_ID NaN) was a false positive — device-ssh.ts already guards with Number.isInteger && >= 0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildSessionContext silently dropped all pre-compaction entries when compaction.firstKeptEntryId was missing from the path (the codec only warns on load). Now keeps them. Red-before-green spec; verify green (agent 190).
🤖 Generated with Claude Code