Skip to content

Add PCIC Node#46

Merged
mishaschwartz merged 4 commits intoDACCS-Climate:mainfrom
pacificclimate:main
Mar 9, 2026
Merged

Add PCIC Node#46
mishaschwartz merged 4 commits intoDACCS-Climate:mainfrom
pacificclimate:main

Conversation

@QSparks
Copy link
Copy Markdown
Contributor

@QSparks QSparks commented Mar 6, 2026

Adds the PCIC Garry Oak node to the registry.

Copy link
Copy Markdown
Collaborator

@mishaschwartz mishaschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QSparks

I forget why but we need the date_added field in order for the tests to pass even though we don't want to include a "date_added" field until the node is actually added. I've put one in there for now if you can approve the change and then we can double check that the tests do actually pass and then we're good to go!

Also FYI, the reason why the Red Oak node is named that is because UofT has an oak theme for a lot of its stuff since there is an oak on the UofT coat of arms. I'm happy for you guys to use the oak theme as well but I just wanted to make sure you were aware that it was chosen because it's a UofT thing, not a Marble thing.

Co-authored-by: mishaschwartz <4380924+mishaschwartz@users.noreply.github.com>
@QSparks QSparks requested a review from mishaschwartz March 9, 2026 15:15
@mishaschwartz mishaschwartz merged commit aaaa9d9 into DACCS-Climate:main Mar 9, 2026
1 check passed
@mishaschwartz
Copy link
Copy Markdown
Collaborator

I manually ran the registry update script and so we now officially have a new node in the registry!!

https://marbleclimate.com/node.html#PCICGarryOak

Thanks @QSparks

@huard
Copy link
Copy Markdown
Contributor

huard commented Mar 10, 2026

Nice! I also wonder about the node name. Is there a risk of confusion between the two "oaks"?

@QSparks
Copy link
Copy Markdown
Contributor Author

QSparks commented Mar 10, 2026

Thanks, that’s useful context. “Garry Oak” was suggested because it keeps the oak theme while giving it a distinctly Victoria identity through a local species. So there was some intentional thematic alignment, but also an effort to make it regionally specific.

If there are concrete concerns about confusion, we’re open to considering them. Otherwise, Garry Oaks are important to BC, and we think our users will understand that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants