feat(c3) : Add ability to evaluate cost of C3 plan#44
Conversation
LCOV of commit
|
|
The overall structure really looks good to me 🔥 . I haven't taken a deep dive, but having some nested namespaces for trajectory evaluation would make sure they are well scoped. Letting the functions be declared static as part of a class is also an option but not required. |
|
This PR is ready for review. One remaining issue is the noble check failed due to: @Meow404 I don't believe this is an issue because of the new code in this PR, but please advise if there's something to be done. |
|
@ebianchi A few minor points before I review:
|
|
Thanks for pointing out the outdated comments and how to match formatting to the rest of the code. Those are done. As for the variadic template style approach for the |
|
After some further consideration, we decided it may be desirable to sum costs contributed by state, input, and/or contact force trajectories that don't match lengths |
Addresses #31
This change is