feat(agoric): add mint parameter change support for inflation settings#74
Closed
dckc wants to merge 2 commits into
Closed
feat(agoric): add mint parameter change support for inflation settings#74dckc wants to merge 2 commits into
dckc wants to merge 2 commits into
Conversation
Add mint module support to the Agoric parameter-change proposal flow so users can draft inflation parameter updates from the UI, similar to existing gov voting/tally support.\n\nWhat is included:\n- add MintParams typing for /cosmos/mint/v1beta1/params response shape\n- add mintParamsQuery in lib/queries\n- add selectMintParams selector and limit editable rows to inflation_min, inflation_max, inflation_rate_change\n- add a new "Mint Parameters" descriptor in config/agoric/params so it appears in the Parameter Change Type selector\n- add submit mapping from snake_case API fields to legacy ParameterChangeProposal keys required by chain params updates:\n - inflation_min -> InflationMin\n - inflation_max -> InflationMax\n - inflation_rate_change -> InflationRateChange\n with subspace "mint" and JSON-stringified values\n- extend query e2e coverage with a mint params snapshot test\n\nWhy this mapping is explicit:\nAgoric governance parameter-change execution uses MsgExecLegacyContent + ParameterChangeProposal key names in PascalCase for mint fields. Historical passed proposals use the exact keys above. Capturing this map in code avoids accidental regressions (for example, submitting snake_case keys that look valid in UI but fail at execution time).\n\nScope notes:\n- this change intentionally does not expose mint_denom, goal_bonded, or blocks_per_year in the editable table because issue DCFoundation#73 requested inflation parameter adjustments specifically\n- existing swingset/gov parameter behavior is unchanged\n\nValidation performed:\n- yarn lint\n- yarn ts:check
❌ Deploy Preview for cosmos-proposal-builder failed.
|
dckc
force-pushed
the
gibson-2025-05-drop-ist
branch
from
b32afad to
6c9188d
Compare
Remove `main` from the selectable network list in the network context so deploy-preview environments cannot target mainnet during manual testing. This is intentionally a minimal one-file change and easy to revert by re-adding `"main"` to `_netNames`. Behavior change: - `main` no longer appears in the network dropdown - `?network=main` is treated as invalid and not selected Rationale: - reduce risk of accidental mainnet proposal submissions while validating preview builds - keep the change isolated from feature work so it can be removed cleanly after testing
dckc
force-pushed
the
gibson-2025-05-drop-ist
branch
from
6c9188d to
efd032f
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: Unreviewed LLM output.
Adds mint parameter adjustments support to the Agoric parameter change flow, covering:
Implementation details:
MintParamstyping andmintParamsQueryfor/cosmos/mint/v1beta1/paramsselectMintParamsto expose only the inflation fields in the formMint Parametersdescriptor in the Agoric param descriptor listinflation_min->InflationMininflation_max->InflationMaxinflation_rate_change->InflationRateChangeValidation:
yarn lintyarn ts:checkCloses #73