(POC) feat: Add composable settings support to form components#1164
Draft
(POC) feat: Add composable settings support to form components#1164
Conversation
- Introduced a new module for composable settings fields, allowing components to have additional fields rendered before or after them. - Updated the mapping functions to include composable settings in the component definitions. - Enhanced the form definition schema to accommodate before/after component rendering.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This spike replaces the hardcoded
instructionTextlogic with a more flexible composition pattern, letting components include other components via before and after properties.Sister PR DEFRA/forms-engine-plugin#228
Changes
forms-model
• types.ts: Added
ComposableComponentinterface with before and after props; extendedComponentDefaccordingly• form-definition/index.ts: Updated schema to allow before and after (using Joi.any() for spike simplicity — recursive validation needed later)
forms-engine-plugin
•
ComposableComponentCollection.ts: New class extendingComponentCollectionto support before/after relationships•
component-renderer.ts: New helper for recursively rendering composable components while preserving type integrity•
QuestionPageController.ts: Detects composable components and switches toComposableComponentCollection, otherwise defaults to the regular collectionHow It Works
1. Components can define before and after subcomponents
2. Engine detects composable components and uses the enhanced collection
3. Rendering order: before → main → after
4. Fully backward compatible — existing forms continue to work