Skip to content

feat/df-820: Reads payment api key from secrets#314

Merged
jbarnsley10 merged 14 commits intomainfrom
feat/df-820-api-keys
Mar 5, 2026
Merged

feat/df-820: Reads payment api key from secrets#314
jbarnsley10 merged 14 commits intomainfrom
feat/df-820-api-keys

Conversation

@jbarnsley10
Copy link
Contributor

@jbarnsley10 jbarnsley10 commented Feb 24, 2026

Proposed change

Reads payment API keys from secrets served by forms-manager

Jira ticket: DF-820

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

@davidjamesstone
Copy link
Contributor

Although not part of this PR, it would be nice to move PaymentDispatcherArgs into types.ts and have it inherit from the base ExternalArgs. That way args.controller and args.controller.model are PageController and FormModel rather than custom objects.

https://github.com/DEFRA/forms-engine-plugin/pull/314/changes#diff-31b13e4392949f2e246107b05f25eab0f997373f2cc175ef3eaaccc1c5303269L346

Thanks Jez

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2026

@jbarnsley10 jbarnsley10 merged commit 7f57609 into main Mar 5, 2026
23 checks passed
@jbarnsley10 jbarnsley10 deleted the feat/df-820-api-keys branch March 5, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants