Skip to content

SUI-1820 - Write Confident matches back to eclipse#370

Merged
tomhawkin merged 6 commits into
mainfrom
feat/SUI-1820
Jul 15, 2026
Merged

SUI-1820 - Write Confident matches back to eclipse#370
tomhawkin merged 6 commits into
mainfrom
feat/SUI-1820

Conversation

@tomhawkin

Copy link
Copy Markdown
Collaborator

Summary

added UpdatePerson mutation to save strong match NHS numbers back to eclipse.
Refactored GraphQLProcessor

Changes

  • split GraphQlProcessor method up to reduce complexity
  • added mutation to save back nhs numbers

Validation

  • unit tests
  • run against fake api

@tomhawkin
tomhawkin requested a review from a team as a code owner July 14, 2026 09:16
@tomhawkin
tomhawkin requested a review from jtaylor100 July 14, 2026 09:25
Comment thread src/SUI.Client/SUI.Client.GraphQLProcessJob/Infrastructure/GraphQLProcessor.cs Outdated
Comment thread src/SUI.Client/SUI.Client.GraphQLProcessJob/Infrastructure/GraphQLProcessor.cs Outdated
@jtaylor100
jtaylor100 self-requested a review July 14, 2026 13:19
…b timer. fixed an issue with mutations not passing validation because they were missing the personTypes property
Comment thread src/SUI.Client/SUI.Client.GraphQLProcessJob/Infrastructure/GraphQLProcessor.cs Outdated
Comment thread src/SUI.Client/SUI.Client.GraphQLProcessJob/Infrastructure/GraphQLProcessor.cs Outdated
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Health
Matching 74% 49%
SUI.Client.GraphQLProcessJob 4% 1%
External 44% 32%
SUI.Client.StorageProcessJob 97% 83%
SUI.DBS.Response.Logger.Core 93% 72%
SUI.Client.Core 93% 87%
Shared 92% 84%
AppHost 100% 100%
suiw 100% 100%
Summary 49% (4256 / 8764) 16% (1143 / 7020)

@sonarqubecloud

Copy link
Copy Markdown

@jtaylor100
jtaylor100 self-requested a review July 15, 2026 13:43
@tomhawkin
tomhawkin merged commit 20ff0fd into main Jul 15, 2026
5 of 6 checks passed
@tomhawkin
tomhawkin deleted the feat/SUI-1820 branch July 15, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants