Skip to content

Refactor school search - #259

Open
stusherwin wants to merge 4 commits into
mainfrom
search-page-fixes
Open

Refactor school search#259
stusherwin wants to merge 4 commits into
mainfrom
search-page-fixes

Conversation

@stusherwin

@stusherwin stusherwin commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR does the following:

  • Refactors search page from separate Index and Search actions to a single Index action
  • Search landing page route remains as /find-a-school
  • Search results route changes from /find-a-school/search?query=XXX&page=1 to /find-a-school?query=XXX&page=1

Related Trello Ticket

https://trello.com/c/GHPzXyKg/316-search-page-issues

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Tested on Local/Review

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have verified accessibility requirements are met

@stusherwin stusherwin changed the title wip Refactor school search Jun 23, 2026
@stusherwin
stusherwin marked this pull request as ready for review June 23, 2026 12:35
@stusherwin stusherwin added the deploy deploy application label Jun 25, 2026
@github-actions

Copy link
Copy Markdown

Deployments

Review app is available at these URLs:
https://get-school-improvement-insights-pr-259.test.teacherservices.cloud

@github-actions

Copy link
Copy Markdown

Code Coverage Report: Only Changed Files listed

Package Coverage
Overall Coverage 🟢 69.81%

Minimum allowed coverage is 0%, this run produced 69.81%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy deploy application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant