Add dedicated /school/secondary route for secondary school journeys and area path - #282
Merged
Merged
Conversation
mahmoodcli
changed the title
mahmoodcli
changed the title
Deployments
|
added 2 commits
July 14, 2026 14:17
…asures-content-updates # Conflicts: # SAPSec.Web/Views/School/Attendance.cshtml # Tests/SAPSec.Test.Integration/Tests/SchoolControllerIntegrationTests.cs
…path-for-Secondary # Conflicts: # SAPSec.Web/Constants/Routes.cs
stusherwin
requested changes
Jul 14, 2026
stusherwin
requested changes
Jul 22, 2026
|
|
||
| var redirectResult = result.Should().BeOfType<RedirectResult>().Subject; | ||
| redirectResult.Url.Should().Be("/school/123456"); | ||
| redirectResult.Url.Should().Be("/school/secondary/123456"); |
Collaborator
There was a problem hiding this comment.
Looks like this was missed
|
|
||
| var redirectResult = result.Should().BeOfType<RedirectResult>().Subject; | ||
| redirectResult.Url.Should().Be("/school/123456"); | ||
| redirectResult.Url.Should().Be("/school/secondary/123456"); |
Collaborator
There was a problem hiding this comment.
Also other paths in this file
vipinsamreddy
approved these changes
Jul 23, 2026
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
stusherwin
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change introduces a dedicated secondary-school URL path under /school/secondary/{urn}.
Related Trello Ticket
https://trello.com/c/Ih9RRXAL
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Screenshots (if applicable)
Add UI changes, logs, console outputs anything to help reviewers.