Merged
Conversation
* feat: centralize fee logic and add Bitcoin deposit forwarding Move getSendFeeRate() into BitcoinBasedFeeService using template method pattern, eliminating duplicate fee multiplier logic across Bitcoin and Firo services. Add dedicated Bitcoin deposit forwarding with explicit UTXO selection and subtract_fee_from_outputs for accurate fee handling. * refactor: extract sendManyFromAddress to BitcoinBasedClient Move UTXO-from-address fetching and input mapping into a shared sendManyFromAddress method on BitcoinBasedClient. FiroClient overrides it with its raw-transaction approach. Simplifies forwardBitcoinDeposit to a single method call. * fix: throw error if no UTXOs are available
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
* feat: support different currencies for brokerbot. * test: fix. * formatting. * test: fix.
TaprootFreak
previously approved these changes
Mar 9, 2026
davidleomay
previously approved these changes
Mar 9, 2026
* fix: remove ICP service passthrough methods and use client directly * fix: pass Asset to ICP client instead of canisterId/decimals separately * fix: move ICP forward fee deduction from client to caller
Add deploy script and documentation entries plus dev/prd parameter files so the keep-market hummingbot instance can be deployed consistently.
- Add autoheal service to auto-restart firod on healthcheck failure - Increase memory limit from 6144M to 8192M for Spark/Lelantus proofs - Add log rotation (100m, 3 files) - Adjust healthcheck: interval=60s, timeout=30s, retries=3 - Sync firo.conf with remote: mempool settings, buffer limits, dbcache, rpcworkqueue
TaprootFreak
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist