fix: add kycFileId > 0 filter to KYC stats queries#3391
Draft
TaprootFreak wants to merge 1 commit intodevelopfrom
Draft
fix: add kycFileId > 0 filter to KYC stats queries#3391TaprootFreak wants to merge 1 commit intodevelopfrom
TaprootFreak wants to merge 1 commit intodevelopfrom
Conversation
Stats queries (countByDateRange, getMaxKycFileIdByDateRange) did not filter on kycFileId > 0, unlike getUserDatasWithKycFile. This caused records without a KYC file to be counted in the yearly statistics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kycFileId > 0filter tocountByDateRange()andgetMaxKycFileIdByDateRange()inuser-data.service.tskycFileId = NULL) were included in the KYC file yearly statisticsgetUserDatasWithKycFile(), which already filters onkycFileId > 0Affected
GET /support/kycFileStatsendpoint (compliance KYC stats page)Test plan