Merged
Conversation
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
* fix: remove vat and total from multi tx pdf. * chore: warning.
TaprootFreak
previously approved these changes
Mar 11, 2026
* fix: ICRC token scanning bugs and robustness improvements - Fix batch loop break condition to use raw transaction count instead of filtered transfers, preventing skipped blocks with mint/burn/approve txs - Pass fromBlock/toBlock through to ICRC token scanning for correct pollAddress behavior - Reject assets with missing decimals instead of silently falling back to 8 - Reduce verbose logging by removing full address list dump every minute * feat: unified global scanning + settings persistence for ICP register strategy Replace per-address Rosetta calls with global query_blocks scan for native ICP transfers. Persist scan progress in settings table per canister ID for both native ICP and ICRC tokens. Unify both code paths with consistent batched scanning, client-side filtering, and cold-start handling. * test: update register strategy test for SettingService dependency * refactor: consolidate ICP scan state into single JSON setting Replace 5 individual setting entries (icpLastScannedBlock + one per canister) with a single icpLastScannedBlocks JSON entry using getObj/setObj. * refactor: use asset ID as scan state key instead of canister ID * refactor: deduplicate native and ICRC scan logic Extract shared fetchTransfersBatched (batch loop) and scanAndCollect (cold-start + persistence) to eliminate duplication between native ICP and ICRC token scanning paths. * chore: refactoring --------- Co-authored-by: David May <david.leo.may@gmail.com>
TaprootFreak
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist