Merged
Conversation
* Add Silent Payment (BIP-352) address support - Extend Bitcoin address regex to accept sp1 addresses - Add BITCOIN_SILENT_PAYMENT to UserAddressType enum - Implement verifySilentPayment() using ECDSA recovery against B_spend - Route sp1 addresses to SP verification in verifySignature() - Add unit tests for address detection and signature verification * Fix SP test: use correct bech32m HRP 'sp' instead of 'sp1' The bech32m separator '1' is added automatically by the encoder. HRP 'sp' produces 'sp1...' (correct), HRP 'sp1' would produce 'sp11...' (wrong). Tests now match real BIP-352 address format. * Add SP address to config format validation test Ensures the allAddressFormat regex correctly matches real Silent Payment addresses in the DTO validation layer. * Refactor SP verification: test real service instead of local copy - Make verifySilentPayment() and encodeVarint() static (pure functions) - Replace duplicated logic in tests with CryptoService method call - Fix import ordering (scoped packages before unscoped) * Add SP address tests to bitcoin crypto.service.spec Consistent with the existing pattern of testing getBlockchainsBasedOn and getAddressType for every supported address type.
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
* feat: add Railgun blockchain assets and base fees Add 6 Railgun-shielded ERC-20 assets (WETH, USDT, dEURO, ZCHF, DAI, WBTC) with matching base fee entries for buy/sell transactions. * fix: set Railgun assets to not buyable/sellable and extend base fee IDs - Set buyable=0, sellable=0 for all Railgun assets (no payout infra yet) - Add fee IDs 7, 8, 19, 26, 27, 28 (Tier2-Personal/Business/SoleProprietorship for all payment directions) to prevent "Base fee is missing" errors * fix: set Railgun assets to buyable=1 (OnRamp), sellable=0 (no OffRamp yet) * fix: revert fee IDs to match production DB structure Production DB shows IDs 7,8 are Tier1 (short lists), 19-24 don't exist, and 25-28 are Talium-specific. Only IDs 4-6, 10-12, 16-18 are Tier2 base fees with explicit asset lists that need new assets appended.
* fix: railgun asset migration * chore: refactored SP signature verification * fix: JUSD price observer * fix: Spark token optimization * fix: test * fix: tests 2 * fix: tests 3
davidleomay
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist