Merged
Conversation
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
* Fix KYC ContactData step not completing on mail update When PUT /v2/user/mail is called, initializeProcess() returns early if a ContactData step already exists, even if the step is still InProgress. This prevents the KYC level from advancing from 0 to 10. Now checks for a pending ContactData step and completes it with the user's email when available, then calls updateProgress() to advance the KYC level. * Add missing step log when completing ContactData via mail update
* Log failed mail update attempts on conflict When a user tries to set an email that already belongs to another account, the attempt was silently lost. Now creates a KYC log entry with the attempted mail and error reason before throwing the ConflictException. * Fix prettier formatting
When PUT /v2/user/mail is called with an email that already belongs to another account, the pending ContactData step was left unchanged in InProgress status with no record of the attempt. Now fails the step with the attempted mail and error reason (matching the behavior of PUT /v2/kyc/data/contact), and creates a step log.
davidleomay
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist