fix: exclude third-party deposits from Scrypt EUR pending balance#3480
Merged
TaprootFreak merged 1 commit intodevelopfrom Mar 20, 2026
Merged
fix: exclude third-party deposits from Scrypt EUR pending balance#3480TaprootFreak merged 1 commit intodevelopfrom
TaprootFreak merged 1 commit intodevelopfrom
Conversation
Third-party EUR deposits to Scrypt (identifiable by txId=null) were included in the receiver list, causing toScrypt to go negative and get clamped to 0 — making pending DFX transfers invisible in the FinancialDataLog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toScryptto go negative (large foreign amounts with no matching sender), which got clamped to 0eurReceiverScryptExchangeTxbytxIdbeing present — DFX deposits always have a txId (DEPOSIT-XXXXX), foreign deposits havenullTest plan
toScryptpending amounts for Scrypt/EUR assettoScryptis no longer clamped to 0 when foreign deposits are present