Display bank fee breakdown (fixed + percent) separately#1008
Merged
TaprootFreak merged 2 commits intodevelopfrom Mar 17, 2026
Merged
Display bank fee breakdown (fixed + percent) separately#1008TaprootFreak merged 2 commits intodevelopfrom
TaprootFreak merged 2 commits intodevelopfrom
Conversation
- Show bankFixed and bankPercent as separate lines when available - Fall back to combined bank fee for backwards compatibility - Add local type extension for Fees interface until package is updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bankFixedandbankPercentas separate lines in fee breakdownbankfee when breakdown is not available (backwards compatible)Feesinterface (remove after@dfx.swiss/reactis updated)Related PRs
Changes
exchange-rate.tsx— split "Bank fee" into "Bank fee (fixed)" and "Bank fee (percent)"transaction.screen.tsx— same split for transaction history viewtypings/dfx-react.d.ts— temporary type extensionTest plan