Merged
Conversation
* fix: add public key requirement for ICP CLI login ICP signature verification requires the public key to derive and validate the principal. Without it, the API rejects the login with "Public key is required for ICP signature verification". Add Blockchain.INTERNET_COMPUTER to the requiresKey list alongside Cardano and Arweave. * fix: pass key parameter through URL-based login Add key to AppParams and forward it to createSession in handleParamSession so that URL-based login works for blockchains that require a public key (Cardano, Arweave, ICP). * add key parameter
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
davidleomay
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist