Skip to content

fix: add widget build to PR CI and remove unused imports#993

Merged
TaprootFreak merged 1 commit intodevelopfrom
fix/pr-ci-widget-build
Mar 12, 2026
Merged

fix: add widget build to PR CI and remove unused imports#993
TaprootFreak merged 1 commit intodevelopfrom
fix/pr-ci-widget-build

Conversation

@TaprootFreak
Copy link
Collaborator

Summary

  • Add npm run widget:dev step to PR CI workflow so frontend build errors (like ESLint violations) are caught before merging into develop
  • Remove unused KycChangeAddressData and KycChangeNameData imports from kyc.screen.tsx that caused the DEV CI/CD build to fail (Release: develop -> main #985)

Context

PR #990 introduced unused imports in kyc.screen.tsx. This wasn't caught because the PR CI workflow didn't include the widget build. The error only surfaced after merging to develop, when the DEV CI/CD pipeline ran npm run widget:dev with CI=true (treating warnings as errors).

Test plan

  • PR CI should now run the widget build step and pass
  • DEV CI/CD build should no longer fail on the unused imports

Add widget build step to PR CI workflow to catch frontend build errors
before merging. Remove unused KycChangeAddressData and KycChangeNameData
imports from kyc.screen.tsx that caused the DEV build to fail.
@TaprootFreak TaprootFreak merged commit 6dc3e0f into develop Mar 12, 2026
6 checks passed
@TaprootFreak TaprootFreak deleted the fix/pr-ci-widget-build branch March 12, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants