[ feat ] ssh 실행 시 docker-tf bash 나오는 현상 해결 및 v260501 버전 과 v260403 병합#32
Merged
Conversation
[fix] 기존 사용자의 컨테이너 변경 시 ~/.bashrc conda initialize 블록 업데이트
There was a problem hiding this comment.
Pull request overview
This PR updates the DECS Docker image (decs:260501) to add optional browser-based GUI access via Xfce + TigerVNC + noVNC, and documents the new capability in the README.
Changes:
- Install Xfce/TigerVNC/noVNC (and dependencies) and expose the noVNC port (6080).
- Add
ENABLE_VNC-gated startup logic inentrypoint.shto runvncserverandwebsockify. - Document GUI usage, ports, and related environment variables in
README.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| README.md | Adds 260501 release notes and documents noVNC-based GUI access and environment variables. |
| entrypoint.sh | Adds start_novnc() and bootstraps user dotfiles from /etc/skel when missing. |
| Dockerfile | Installs GUI/VNC/noVNC packages and exposes port 6080 for noVNC. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+105
to
+107
| vnc_password=$(tr -d '\r\n' < "$vnc_password_file" | head -c 8) | ||
| else | ||
| vnc_password=$(tr -dc A-Za-z0-9 </dev/urandom | head -c 8) |
|
|
||
| pkill -f "websockify.*$novnc_port" >/dev/null 2>&1 || true | ||
| echo "trying noVNC on 0.0.0.0:$novnc_port..." | ||
| nohup websockify --web=/usr/share/novnc "0.0.0.0:$novnc_port" "localhost:$vnc_port" >/tmp/novnc.log 2>&1 & |
| `260501` 버전부터 브라우저 기반 GUI 접속을 지원합니다. GUI 접속은 기본 비활성화 상태이며, 컨테이너 생성 시 `ENABLE_VNC=true` 환경변수를 전달한 경우에만 시작됩니다. | ||
|
|
||
| - 컨테이너 내부 noVNC 포트: `6080` | ||
| - 컨테이너 내부 VNC 포트: `localhost:5901` 전용 |
Comment on lines
+39
to
+41
| ### GUI 접속(noVNC) | ||
| `260501` 버전부터 브라우저 기반 GUI 접속을 지원합니다. GUI 접속은 기본 비활성화 상태이며, 컨테이너 생성 시 `ENABLE_VNC=true` 환경변수를 전달한 경우에만 시작됩니다. | ||
|
|
dongmin0204
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
🌱 작업 사항
해당 Pull Request에서 수행한 작업 목록을 제시해야 합니다.
🌱 참고 사항
기능을 만들 때 생긴 이슈에 대해서 다른사람들이 참고해야 할 사항을 적습니다.