Skip to content

Fix index in CCPACSFuselageProfiles::GetProfile#1110

Merged
merakulix merged 6 commits into
masterfrom
merakulix-patch-1
Jul 24, 2025
Merged

Fix index in CCPACSFuselageProfiles::GetProfile#1110
merakulix merged 6 commits into
masterfrom
merakulix-patch-1

Conversation

@merakulix

@merakulix merakulix commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

This fixes an error that occurred in PR #1083. When updating the getter functions regarding const correctness, the decrement by 1 of the index was lost.

Description

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

This fixes an error that occurred in PR #1083. When updating the getter functions regarding const correctness, the decrement by 1 of the index was lost.
@codecov

codecov Bot commented Jul 24, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.91%. Comparing base (82bdf2c) to head (5d62da2).

Files with missing lines Patch % Lines
src/fuselage/CCPACSFuselageProfiles.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1110   +/-   ##
=======================================
  Coverage   69.91%   69.91%           
=======================================
  Files         294      294           
  Lines       27285    27285           
=======================================
  Hits        19075    19075           
  Misses       8210     8210           
Flag Coverage Δ
unittests 69.91% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/fuselage/CCPACSFuselageProfiles.cpp 46.80% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@merakulix merakulix merged commit de447d8 into master Jul 24, 2025
15 checks passed
@merakulix merakulix deleted the merakulix-patch-1 branch July 24, 2025 14:51
merakulix added a commit that referenced this pull request Jul 28, 2025
This fixes an error that occurred in PR #1083. When updating the getter functions regarding const correctness, the decrement by 1 of the index was lost. Calling the base class getter functions fixes this, and reduces duplicate code.

Co-authored-by: merakulix <82722016+merakulix@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants