Skip to content

Always display the control devices with the wing#1233

Merged
ole-alb merged 10 commits into
mainfrom
1125-display-control-devices
Oct 20, 2025
Merged

Always display the control devices with the wing#1233
ole-alb merged 10 commits into
mainfrom
1125-display-control-devices

Conversation

@ole-alb

@ole-alb ole-alb commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

Description

Closes #1225

Always display the control surfaces when the whole aircraft or just the wings are displayed in the tiglecreator.

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

@ole-alb ole-alb changed the title always display the control devices with the wing Always display the control devices with the wing Oct 13, 2025
@codecov

codecov Bot commented Oct 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.97%. Comparing base (7166d1d) to head (3c9f87d).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1233   +/-   ##
=======================================
  Coverage   71.97%   71.97%           
=======================================
  Files         308      308           
  Lines       29541    29541           
=======================================
  Hits        21261    21261           
  Misses       8280     8280           
Flag Coverage Δ
unittests 71.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread TIGLCreator/src/TIGLCreatorDocument.cpp Outdated
Comment thread TIGLCreator/src/TIGLCreatorDocument.cpp Outdated
Comment thread TIGLCreator/src/TIGLCreatorDocument.cpp
@ole-alb

ole-alb commented Oct 14, 2025

Copy link
Copy Markdown
Contributor Author

I also encountered a further design decision we should discuss. How do we want to handle transformed flaps? If we open the flap transform window, move the flaps around and then display the whole aircraft, the borders are still at the original position.
(This problem should be resolved with the implementation of a scene graph, but I still wanted to mention it).
What do you think @joergbrech @svengoldberg

Screenshot 2025-10-14 165317

@ole-alb ole-alb requested a review from joergbrech October 14, 2025 14:55
Comment thread TIGLCreator/src/TIGLCreatorDocument.cpp Outdated
Comment thread TIGLCreator/src/TIGLCreatorDocument.cpp
@joergbrech

Copy link
Copy Markdown
Contributor

This problem should be resolved with the implementation of a scene graph, but I still wanted to mention it

Yes, I agree. I suppose the changes in this PR are more a quick fix. Let's not overdo it and focus on the scene graph. Here, this issue should be resolved.

Comment thread TIGLCreator/src/TIGLCreatorDocument.cpp
@ole-alb ole-alb requested a review from joergbrech October 17, 2025 10:20
Comment thread TIGLCreator/src/TIGLCreatorDocument.cpp
Co-authored-by: Jan Kleinert <jan.kleinert@dlr.de>
@ole-alb ole-alb merged commit be6b7bf into main Oct 20, 2025
18 checks passed
@ole-alb ole-alb deleted the 1125-display-control-devices branch October 20, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Always Display Control Devices

2 participants