Systems#1283
Merged
Merged
Conversation
…equence of arguments in wedge
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1283 +/- ##
==========================================
+ Coverage 72.58% 72.96% +0.38%
==========================================
Files 316 322 +6
Lines 27750 28290 +540
==========================================
+ Hits 20141 20643 +502
- Misses 7609 7647 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
joergbrech
requested changes
Jun 10, 2026
joergbrech
approved these changes
Jun 11, 2026
joergbrech
left a comment
joergbrech
left a comment
Contributor
There was a problem hiding this comment.
Awesome! Thanks a lot! There is a new merge conflict due to changes in the code generator. I can take over from here if you like.
Collaborator
Author
|
Sure, feel free to take over ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This extension (partly) covers the new CPACS system specification from CPACSv3.5.
Additional remarks
tigl.hare explicitly numbered starting from 1, whereas enums from the auto-generated classes (e.g., the@componentRepresentationattribute ->GetComponentRepresentation) implicitly start from 0. This certainly causes confusion. UsingGetComponentRepresentationas an example, I have therefore implemented an additional method that returns the corresponding string value viaGetComponentRepresentationAsString. For future consideration: Perhaps there is a way to implement something like this generally as a kind of template in SWIG, so that such...AsStringmethods do not have to be created and maintained manually.How Has This Been Tested?
C++
In
tiglSystems.cpp, both valid and invalid datasets (simpletest-systems.cpacs.xmlandsimpletest-invalid-systems.cpacs.xml, respectively) are tested to cover all new methods and exceptions.Python
The file
test_systems.pywas created to test the accessibility of the wrapped C++ classes, as well as some basic features.Visualization and testing
Python bindings with documentation
Open ToDos:
constrotorcraftrepresentationattributewing-like structures can be modeled viamultiSegmentShapesystemArchitectureevaluationsrotorElementUIDis used instead ofsystemElementUIDsystemElements#1326componentsoptional ingenericSystemChecklist: